BUG fix accuracy loss in sheared image test

GalSim-developers / JAX-GalSim

JAX port of GalSim, for parallelized, GPU accelerated, and differentiable galaxy image simulations.

Other

25 stars 3 forks source link

BUG fix accuracy loss in sheared image test #62

Closed beckermr closed 11 months ago

beckermr commented 11 months ago

When I enabled the upstream galsim tests for shears, I noticed an orders of magnitude loss in accuracy for rendering images in the test. This PR fixes that.

beckermr commented 11 months ago

I added the real space image wrapping but have punted on the k-space stuff. I will submit that in another PR, but it will take longer.

beckermr commented 11 months ago

The accuracy loss was not wrapping but due to the WCS bug.

beckermr commented 11 months ago

Also as a quick comment. The test suite didn't catch the imul etc. bugs, either in galsim or jax-galsim. It may be that we never got the tests to run all the way to the right spot, but definitely something we should think about for future PRs.