GalSim-developers / JAX-GalSim

JAX port of GalSim, for parallelized, GPU accelerated, and differentiable galaxy image simulations.
Other
25 stars 3 forks source link

TST fix CI tests after rebase on main #73

Closed beckermr closed 10 months ago

beckermr commented 11 months ago

This PR fixes the CI tests after the galsim branch was rebased on main.

beckermr commented 10 months ago

I'm working the merge with main here.

ismael-mendoza commented 10 months ago

The tests take significantly longer, is that expected @beckermr ?

beckermr commented 10 months ago

OK @ismael-mendoza this one is ready for review!

beckermr commented 10 months ago

I am not sure. How much longer? A few minutes?

beckermr commented 10 months ago

Looks like ~2x! See the comment below for why.

beckermr commented 10 months ago

OK I went through a bunch of old test suites. As far as I can tell, there is no big regression here. As we've added features, more of the galsim test suite is running and so things go longer. Here are some line items

Those alone accoutn for ~half the time.

beckermr commented 10 months ago

This one is ready to merge @ismael-mendoza!