Closed ismael-mendoza closed 3 months ago
tfp changed their default submodule imports. A direct import of the bessel function we need works fine.
Next issue here is that pytest version 8 broke the test mangling we do on galsim. I am looking into that now.
This PR is ready to go. No API changes here, just updates to the tests etc. Shall we merge @ismael-mendoza?
Also, we should squash when merging. The commit history here is a disaster.
yes I think so! thank you!
I agree with the squash and merge, I removed the other options from the settings
Ahhhhh we should keep the other options in the settings IMHO. I simply meant for this PR we'd squash.
I was thinking it would be good to update to the latest jax version and pin
jax-galsim
to that if possible. Open to discussion on this though.Changes:
_wraps
toimplements
(still won't work forgalsim
but allows code to run, see #93 )tensorflow-probability
, as the newest version does not have thesubstrates
packages?