search

GalaChain / sdk

GalaChain SDK allows you to develop, test, call and deploy chaincodes on GalaChain
Apache License 2.0
124 stars 31 forks source link

Handle Partial Success in fulfillMintAllowanceRequest #267

Open Jehosephat opened 5 months ago

Jehosephat commented 5 months ago

The fulfillMintAllowanceRequest function processes a batch of TokenMintAllowanceRequest entries and updates the state for each request. If an error occurs during the processing of a request, the function records the error but continues processing the remaining requests. This can lead to a situation where some requests are successfully processed and their state updates are committed to the chain, while others fail, resulting in partial success.

fulfillMintAllowance.ts#L171

Certik finding: MAG-01

dzikowski commented 5 months ago

My guess is this is by design - we want partial success, but it needs to be verified. If we want partial success, a comment in code would be useful