search

Galactic-Dev / iSponsorBlock

A jailbreak tweak that implements the sponsorblock api to skip sponsorships in youtube videos.
https://galacticdev.me/iSponsorBlock
GNU General Public License v3.0
245 stars 51 forks source link

Make manual skip popup less obtrusive? #34

Open bestgio opened 3 years ago

bestgio commented 3 years ago

Is your feature request related to a problem? Please describe. Don't think this is related to a problem, but it's more of a suggestion. Not sure if this suggestion really belongs here or more on uYou+.. When a manual skip popup appears, that popup takes about 30% of the video space already when viewing vertically, is there a way we could make that popup take less space?

Describe the solution you'd like Having the manual skip popup takes up less space when viewing in vertical mode, or at least have an option to customize the manual skip popup size if possible

Describe alternatives you've considered Something similar to Youtube Vanced's manual skip popup would be nice in my opinion, it takes less space and doesn't intrude the video as much. I also included screenshots for reference

Additional context Youtube Vanced Manual Skip Option: https://ibb.co/y0bP3Cd

uYou+ Manual Skip Option: https://ibb.co/DkvSSQL

iPhone 13 Pro Max running iOS 15

Cheers!

Galactic-Dev commented 2 years ago

Yeah I'll definitely work on that for the next update. Thanks.

oomek commented 2 years ago

It's been a while since your response. Just curious if the hide button for skip dialog is still planned. Btw not sure if I understand the field Show How Long Skip Notice Will Appear Is it in minutes or seconds? No matter what I enter the skip notice does not disappear automatically.

dayanch96 commented 2 years ago

It's been a while since your response. Just curious if the hide button for skip dialog is still planned. Btw not sure if I understand the field Show How Long Skip Notice Will Appear Is it in minutes or seconds? No matter what I enter the skip notice does not disappear automatically.

Most probably in seconds. He is working on big update, hope he will add hiding skip button option.

oomek commented 2 years ago

@Galactic-Dev Any chance for a proggress update?

dayanch96 commented 1 year ago

Sneak peek of upcoming push 7C4C5A57-1DEC-4D72-85CA-63AD2BFDC321 21FD04FD-3B85-46A7-805B-C22E456B0EF8

oomek commented 1 year ago

Great! Thanks for an update. Are you planning to also add the ability to hide the button if I decide to keep watching, or at least add a timeout so it's not visible for the entire sponsored segment?

dayanch96 commented 1 year ago

It is already added as X button in manual skip popup but you have to build package to use it since it is not released as deb yet. Compact manual skip notifications from screenshots will have 10 sec duration and then will be closed if you dont tap to skip. Compact skipped notification will respect duration that was set in settings (3 sec by default)