Galactic-Dev / iSponsorBlock

A jailbreak tweak that implements the sponsorblock api to skip sponsorships in youtube videos.
https://galacticdev.me/iSponsorBlock
GNU General Public License v3.0
245 stars 51 forks source link

Manual skip options don’t seem to do anything #62

Closed IdirisDT closed 1 year ago

IdirisDT commented 1 year ago

Describe the bug Using the option for how long the manual skip notice shows doesn’t seem to do anything, and the skip button sometimes stays even past when the segment it’s skipping ends

To Reproduce Steps to reproduce the behavior:

  1. Go to iSponsorblock settings
  2. Set how long the skip notice should appear
  3. Open a video with a long intro or ad with the setting for manual skip enabled
  4. Skip notice stays even if you go past the length of the ad or intro, forcing you to press skip

Expected behavior The skip button should disappear after however long I input

The setting should first tell me what unit the number I’m putting in is. I assume it’s seconds but even when I adjust it assuming the unit is minute I don’t get the desired result. Alternatively, just add a button to dismiss the skip button manually.

Screenshots BCC8C8BA-CB65-4191-A981-5E871188DB1D

Please complete the following information:

Additional context I am using uYou+ with a non jailbroken iPhone, so I fully accept that this may be an issue specific to that that this dev doesn’t have any control over, or an issue that’s been fixed but not on whatever version of the tweak uYou+ is using.

There’s also another issue where sometimes pressing the skip button when there are two of the same type of segment in a video causes it to skip to the second one. For example, if a video has two ad segments because it starts by mentioning who the video is sponsored by, and then later on there’s a whole ad read, pressing the skip button while at the first section will sometimes skip to the end of the second section.

Originally I also said the minimum segment duration wasn’t working because it wasn’t, but it suddenly started working once I fiddled with it more. Go figure. This didn’t happen for the skip notice duration setting though, that’s still borked.