search

GalacticDynamics / coordinax

Coordinates in JAX
MIT License
11 stars 3 forks source link

Space #135

Closed nstarman closed 3 months ago

nstarman commented 3 months ago

This is a collection of Vectors. It acts like a single vector. This PR lays the foundation. There's definitely a lot of additional work to get this completed. But given that these are all 0.X releases, I think it's worthwhile to add this feature now and then build upon it before the v0.8 release.

nstarman commented 3 months ago

What do you think of this collection object? multiple dispatch on represent_as makes the transformation of the components relatively simple! (Still a WIP to be sure, but I think we have the correct shape of things).

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 90.32258% with 15 lines in your changes missing coverage. Please review.

Project coverage is 92.82%. Comparing base (39eaa68) to head (ce03ffb).

Files Patch % Lines
src/coordinax/_space.py 93.61% 6 Missing :warning:
src/coordinax/_base_pos.py 25.00% 3 Missing :warning:
src/coordinax/_base.py 90.47% 2 Missing :warning:
src/coordinax/_base_acc.py 50.00% 1 Missing :warning:
src/coordinax/_d1/compat.py 66.66% 1 Missing :warning:
src/coordinax/_d2/compat.py 66.66% 1 Missing :warning:
src/coordinax/operators/_base.py 50.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #135 +/- ## ========================================== + Coverage 92.67% 92.82% +0.15% ========================================== Files 63 64 +1 Lines 2265 2370 +105 ========================================== + Hits 2099 2200 +101 - Misses 166 170 +4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.