search

GalacticDynamics / coordinax

Coordinates in JAX
MIT License
12 stars 3 forks source link

feat: coordinate #230

Open nstarman opened 1 week ago

nstarman commented 1 week ago

WIP.

The major thing to still figure out is how to represent the frame post-transformation. E.g. 

import coordinax as cx
frame = cx.frames.ICRS()
data = cx.CartesianPos3D.from_([1, 2, 3], "kpc")
coord = cx.Coordinate(data, frame)

op = cx.operators.GalileanSpatialTranslationOperator.from_([1, 0, 0], "kpc")

newcoord = op(coord)

newcoord.frame  # What should that be? Maybe just an Operator?
codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 94.73684% with 2 lines in your changes missing coverage. Please review.

Project coverage is 97.03%. Comparing base (0f086fc) to head (2e4f36b).

Files with missing lines Patch % Lines
src/coordinax/_src/frames/core.py 94.11% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #230 +/- ## ======================================= Coverage 97.03% 97.03% ======================================= Files 111 112 +1 Lines 3511 3547 +36 ======================================= + Hits 3407 3442 +35 - Misses 104 105 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

🚨 Try these New Features: