Followup to #425.
That PR was to remove unit checks.
A followup PR should add checking the dimensionality.
This change is because we finally have full unit support across the ecosystem and don't need to check / assign units in a wrapper layer. But to catch errors early we shouldn't get rid of the unit attribute on Parameters entirely. Instead we should check that the Parameter objects have the correct dimensionality.
Followup to #425. That PR was to remove unit checks. A followup PR should add checking the dimensionality. This change is because we finally have full unit support across the ecosystem and don't need to check / assign units in a wrapper layer. But to catch errors early we shouldn't get rid of the unit attribute on Parameters entirely. Instead we should check that the Parameter objects have the correct dimensionality.