Closed adrn closed 3 days ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 96.03%. Comparing base (
33059de
) to head (8218632
). Report is 1 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
OK I think this is ready for another look. IMO we don't need to test AbstractUnitSystemFlag
but coverage is complaining about it...
Previous approving review - rebased and added a test for coverage completeness 💅.
This adds a new (currently not used) set of
Flag
types so we can dispatch on the type of unit system (will be useful for the follow-up to add a newSimulationUnitSystem
). This also adds the ability to extend or override units in an existing unit system via: