Closed adrn closed 2 days ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 96.11%. Comparing base (
31f7560
) to head (a73f9e1
). Report is 1 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This is to add support for unit systems where only two of three of
{length, mass, time}
units need to be specified because the value of G is set to 1 (or some other value). This is analogous to Gala'sSimulationUnitSystem
.For the value of G, I was originally planning to accept
unxt.Quantity | float | int
. But I think this needs to be a concrete value as the computed units need to be passed tounxt.units()
, which under the hood callsastropy.units.Unit
. So the current approach acceptsastropy.units.Quantity | float | int
, but now I'm thinking that this should instead require onlyfloat | int
because it doesn't really make sense to allow someone to pass in a unit-ful G. That would also simplify some logic here. Thoughts?