Galarzaa90 / NabBot

Discord bot for Tibia servers
https://nabbot.xyz
Apache License 2.0
52 stars 25 forks source link

Command `/highscores achievements` is broken #159

Closed TheWrongAlice closed 5 years ago

TheWrongAlice commented 5 years ago

Platform information

Bug information

Scraped data from tibia.com is not being processed. I believe this is due to a difference in data structure for achievements as compared to skills or experience level. I believe the issue is with this line: https://github.com/NabDev/NabBot/blob/0284fb6a0d9294894c3103fce5cb288044b5e90a/cogs/tibia.py#L654 Here is an expectation of a level property which does not exist, as achievements are measured with "points" not "levels".

Steps to reproduce: Run the command in discord: /highscores achievements

Expected result: Leaderboard is displayed

Actual result: Error is displayed

:false:Command Error
KeyError: 'level'
Galarzaa90 commented 5 years ago

It's likely that has been broken for a while and we didn't notice before 🤔

But it's fixed in the dev branch and release should happen this week.