search

Galaxia5987 / Recode2024

Recode of the 2024 robot code in Kotlin
Other
4 stars 1 forks source link

Add marker button for drivers #61

Open Emma03L opened 1 month ago

Emma03L commented 1 month ago

Add option for the drivers to log timestamps and robot pose mid-match in order to mark problems.

rakrakon commented 2 weeks ago

@katzuv @Emma03L I'm a little confused on how do we want to implement this. Could one of you clear it up?

katzuv commented 2 weeks ago

There's a WPILib logging function which can be used. Find it

Hint (only if you need it!) The function is mentioned in the 2025 suggestions page.
Emma03L commented 2 weeks ago

I assume you're talking about DataLogManager.log() and that was my plan But I also wanted a way for it to show up on the timeline in advantage scope and I'm not sure it can do that. If it can't we can log two things with the same button. We could even have separate buttons that log different messages for different kinds of problems, though I'm not sure if it will be comfortable for the drivers.

katzuv commented 2 weeks ago

You can see the log in the console tab, maybe as a discrete value in the line graph. You can also a boolean entry. But I think logging a message is the best way, it can be also color highlighted in the console tab.

rakrakon commented 1 week ago

I tested the code for the alerts, but you can't view the alerts in AD because for some reason they don't show up in the smartDashboard. I also tried to put just a random number in the smartDashboard but i still can't see it. I think this is a bug in the beta. Strangely enough the autoChooser does work properly. @katzuv what do you think?

katzuv commented 1 week ago

I'd like to see the code but I think that the base branch in the PR is incorrect, too much diff https://github.com/Galaxia5987/Recode2024/pull/74#issuecomment-2485753832

katzuv commented 1 week ago

Also, note you can use OutlineViewer to see entries logged to NetworkTables, if that helps. https://docs.wpilib.org/en/stable/docs/software/wpilib-tools/outlineviewer/index.html

rakrakon commented 1 week ago

I changed the base branch. Still doesn't show up in smartDashboard, I checked with outline viewer. @katzuv

katzuv commented 6 days ago

You should be able to see the logs in the "messages" field: Image https://docs.advantagescope.org/tab-reference/console

rakrakon commented 6 days ago

I am seeing the DataLogManager.log, What i can't see is the alerts.

katzuv commented 6 days ago

74 has no code related to alerts so I'm not sure what you expect to see.

rakrakon commented 4 days ago

Sorry, forgot to push the commit.

katzuv commented 2 days ago

now I realize that if you want to see the alerts in AdvantageScope you probably won't see them because they aren't logged. However, they will be logged in the beta version of AdvantageKit so I would just wait for its release which should be soon.