search

GalaxyHunters / Evolution-Machine-Satellite-Galaxies

Creating a Machine-Learning Model for Prediction of Satellite Galaxy Evolution
0 stars 0 forks source link

shape calculation - why shape failed #4

Closed tussbaum closed 5 years ago

Beilinson commented 5 years ago

added new columns: err_msg(s) Before running: "Not run yet" After running: "All good" If iterations passed 100: "iter>iter_max" if particles reaches 20; "px_amount<=px_min"

Beilinson commented 5 years ago

at the end of the catalogue, 12 columns show the state of each satellites radius (further subdivided by particle type). Its a very simple system, since you can easily go to the end and see where exactly it messed up and why (instead of scrolling through 120 columns, trying to find some error)

sgal_shape_df['stars(1kpc)_err_msg'],sgal_shape_df['dm(1kpc)_err_msg'],sgal_shape_df['gas(1kpc)_err_msg'],sgal_shape_df['stars(0.5kpc)_err_msg'],sgal_shape_df['dm(0.5kpc)_err_msg'],sgal_shape_df['gas(0.5kpc)_err_msg'],sgal_shape_df['stars(Rsat)_err_msg'],sgal_shape_df['dm(Rsat)_err_msg'],sgal_shape_df['gas(Rsat)_err_msg'],sgal_shape_df['stars(0.9coldgas)_err_msg'],sgal_shape_df['dm(0.9coldgas)_err_msg'],sgal_shape_df['gas(0.9coldgas)_err_msg']=['Not run yet']*12

Beilinson commented 5 years ago

Do I need any more error messages?

tussbaum commented 5 years ago

what about if the error fraction term did not converge? (There is relative error calculated, each loop, look at that) Look at the code if there is anything else.

Must say, you are doing a great job, keep up this momentum and we are near completion.

On Sat, Sep 14, 2019 at 12:35 AM Beilinson notifications@github.com wrote:

Do I need any more error messages?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/GalaxyHunters/Vela_satellites/issues/4?email_source=notifications&email_token=AAMVJHU7A564DWTEGKBDIOLQJQBSPA5CNFSM4IVXRXT2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6WIAGA#issuecomment-531398680, or mute the thread https://github.com/notifications/unsubscribe-auth/AAMVJHQ4EQL3GFLRGWDGGX3QJQBSPANCNFSM4IVXRXTQ .

--

Ceterum censeo, sit tempus non necessitatem.