Galileo-Galilei / kedro-mlflow

A kedro-plugin for integration of mlflow capabilities inside kedro projects (especially machine learning model versioning and packaging)
https://kedro-mlflow.readthedocs.io/
Apache License 2.0
195 stars 29 forks source link

kedro mlflow cli is broken if configuration is declared in pyproject.toml #157

Closed Galileo-Galilei closed 3 years ago

Galileo-Galilei commented 3 years ago

Description

Kedro enable to declare configuration either in .kedro.yml or in pyproject.toml (in the [tool.kedro] section). We claim to support both, but the CLI commands are not accessible if the project contains only a pyproject.toml file.

Steps to Reproduce

Call kedro mlflow init inside a project with no .kedro.yml file but only a pyproject.toml.

Expected Result

The cli commands should be available (init)

Actual Result

Only the new command is available. This is not considered as a kedro project.

-- Separate them if you have more than one.

Your Environment

Does the bug also happen with the last version on develop?

Yes

Solution

The error comes from the is_kedro_project function which does not consider that a folder is the root of a kdro project if it does not contain a .kedro.yml.

Galileo-Galilei commented 3 years ago

This will wait the migration to kedro>=0.17.0 (cf. #144) in milestone 0.6.0 because kedro has bradnd new utilities to handle this part. This will remove boilerplate code from the plugin and ensure consistency with future kedro changes.