Galileo-Galilei / kedro-mlflow

A kedro-plugin for integration of mlflow capabilities inside kedro projects (especially machine learning model versioning and packaging)
https://kedro-mlflow.readthedocs.io/
Apache License 2.0
198 stars 32 forks source link

Improve test coverage #7

Closed Galileo-Galilei closed 4 years ago

Galileo-Galilei commented 4 years ago

Test coverage is very poor at the moment. the goal is too get as fast as possible at 100% coverage with test for "normal" use and to add edge case when a bug is encountered. Once coverage will reach 100%, we will enforce keeping this 100% coverage for merging on master in the CI chain.

I'll edit this post with the test cases I'll come up with:

Galileo-Galilei commented 4 years ago

Hello @kaemo, I have finally completed the unit testing phase and reach 100% coverage. I merged the results on the develop branch. You have detailed explanation of the changes in the CHANGELOG.

By now, the tests are only unit test and do not contain integration test. If the formatting of some objects change in a future kedro release, some test will not break even if the the new kedro release is no longer compatible with the plugin (I have specifically in mind the run_params argument of the pipeline hook, but template changes can cause the same type of problem).

I think that integration tests are something really different and they should be tracked in another issue. I close this issue, but feel free to reopen it if needed.