Galileo-Galilei / kedro-pandera

A kedro plugin to use pandera in your kedro projects
https://kedro-pandera.readthedocs.io/en/latest/
Apache License 2.0
33 stars 4 forks source link

Remove print statement and add linting #45

Closed noklam closed 11 months ago

noklam commented 11 months ago

Description

Why was this PR created? Fix #44

Development notes

What have you changed, and how has this been tested?

Notice

codecov[bot] commented 11 months ago

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.11% :warning:

Comparison is base (a631c1a) 89.21% compared to head (fa7842c) 89.10%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #45 +/- ## ========================================== - Coverage 89.21% 89.10% -0.11% ========================================== Files 5 5 Lines 102 101 -1 ========================================== - Hits 91 90 -1 Misses 11 11 ``` | [Files Changed](https://app.codecov.io/gh/Galileo-Galilei/kedro-pandera/pull/45?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yolan+Honor%C3%A9-Roug%C3%A9) | Coverage Δ | | |---|---|---| | [kedro\_pandera/framework/config/resolvers.py](https://app.codecov.io/gh/Galileo-Galilei/kedro-pandera/pull/45?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yolan+Honor%C3%A9-Roug%C3%A9#diff-a2Vkcm9fcGFuZGVyYS9mcmFtZXdvcmsvY29uZmlnL3Jlc29sdmVycy5weQ==) | `100.00% <ø> (ø)` | | | [kedro\_pandera/framework/hooks/pandera\_hook.py](https://app.codecov.io/gh/Galileo-Galilei/kedro-pandera/pull/45?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yolan+Honor%C3%A9-Roug%C3%A9#diff-a2Vkcm9fcGFuZGVyYS9mcmFtZXdvcmsvaG9va3MvcGFuZGVyYV9ob29rLnB5) | `57.69% <ø> (ø)` | | | [kedro\_pandera/framework/cli/cli.py](https://app.codecov.io/gh/Galileo-Galilei/kedro-pandera/pull/45?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yolan+Honor%C3%A9-Roug%C3%A9#diff-a2Vkcm9fcGFuZGVyYS9mcmFtZXdvcmsvY2xpL2NsaS5weQ==) | `100.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

noklam commented 11 months ago

Fix a few small things hopefully it will all pass now.

noklam commented 11 months ago

the apache2.0 link is still failing for no reason, the link works perfectly fine.

Galileo-Galilei commented 11 months ago

The apache 2 often fails randomly, I think this is due to a kind or DDOS protection. Nothing to worry about.

Thanks for the PR!