Galileo-Galilei / kedro-pandera

A kedro plugin to use pandera in your kedro projects
https://kedro-pandera.readthedocs.io/en/latest/
Apache License 2.0
33 stars 4 forks source link

validate output data and add tests #66

Closed mjspier closed 2 months ago

mjspier commented 3 months ago

Description

Also validate output data

Development notes

Checklist

Notice

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (56d9cd1) to head (81b67fe).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #66 +/- ## =========================================== + Coverage 94.05% 100.00% +5.94% =========================================== Files 5 5 Lines 101 112 +11 =========================================== + Hits 95 112 +17 + Misses 6 0 -6 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Galileo-Galilei commented 3 months ago

Thank you very much for the PR. The only required change is to avoid multiple validation of the same dataset, all others are nitpicks you can ignore.

Galileo-Galilei commented 3 months ago

Thank you for the update. There is only the double validation check to perform and it's good to go!

Galileo-Galilei commented 2 months ago

Thank you for everything, it's merged!