Galileo-Galilei / kedro-pandera

A kedro plugin to use pandera in your kedro projects
https://kedro-pandera.readthedocs.io/en/latest/
Apache License 2.0
33 stars 4 forks source link

:sparkles: Add keyword arguments to schema's validate() method (#73) #78

Closed michal-mmm closed 1 month ago

michal-mmm commented 1 month ago

Description

(#73)

Development notes

What have you changed, and how has this been tested?

Checklist

Notice

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (8904511) to head (bf00a21).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #78 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 5 5 Lines 114 116 +2 ========================================= + Hits 114 116 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

michal-mmm commented 1 month ago

Hey @Galileo-Galilei, I've made the changes to address the issue in (#73). I've implemented your proposed solution, which works for now. The code could use some additional tests (e.g., testing other arguments of validate method) and refactoring , but I currently don't have enough time to do that.

Galileo-Galilei commented 1 month ago

Thank you very much for the PR. I'll have a look by the end of the week, and release a new version to PyPI as soon as it is merged.