Closed michal-mmm closed 1 month ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 100.00%. Comparing base (
8904511
) to head (bf00a21
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Hey @Galileo-Galilei, I've made the changes to address the issue in (#73). I've implemented your proposed solution, which works for now. The code could use some additional tests (e.g., testing other arguments of validate
method) and refactoring , but I currently don't have enough time to do that.
Thank you very much for the PR. I'll have a look by the end of the week, and release a new version to PyPI as soon as it is merged.
Description
(#73)
Development notes
What have you changed, and how has this been tested?
validate_kwargs
as suggested in the issue (#73)pyspark
dataframes"pyspark>=2.2, <4.0"
test dependency. The version numbers are consistent withkedro-datasets
Checklist
CHANGELOG.md
file. Please respect Keep a Changelog guidelines.Notice
[x] I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":
I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.
I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorised to submit this contribution on behalf of the original creator(s) or their licensees.
I certify that the use of this contribution as authorised by the Apache 2.0 license does not violate the intellectual property rights of anyone else.