search

Galileo88 / Galileos-Planet-Pack

Galileo's Planet Pack
Other
41 stars 18 forks source link

Fix KSP version compatibility in netkan files #69

Closed DasSkelett closed 3 years ago

DasSkelett commented 3 years ago

Problem

The version overview for GPP, GPPCloudsHighRes, GPPCloudsLowRes and GPPSecondary in CKAN currently looks like this: while the forum thread says this: image

GPPTextures doesn't look much better.

Changes

The hardcoded compatibilities in all netkan files are removed. That's what the AVC .version file included in the download (and its online copy in the repo) is for, which CKAN will use as source of compatibility data from now on.

The .version file got a new KSP_VERSION_MAX to make sure the releases don't have unbounded future compatibility. This means a tiny bit of extra maintenance to update the maximum compatibility when new KSP versions drop, but gives an extra safeguard to avoid users installing it even if it is broken for the new release. Preemptive info: No new release is required after the version file in the repository got updated for a new KSP release, since the URL property of the file included in the zip points to the remote file, CKAN will detect the change and update the metadata accordingly.

The zip for GPPTextures doesn't have a version file, so it's now unbounded, which shouldn't be much of a problem since it is dependent on GPP anyway.

To reflect this in CKAN, GPP is added to the dependencies of GPPTextures, as well as GPPCloudsHighRes, GPPCloudsLowRes and GPPSecondary.

The changes from #64 are incorporated as well.

Pinging @Galileo88 @OhioBob to make sure the notifications arrive. @HebaruSan FYI

Closes #64

DasSkelett commented 3 years ago

@OhioBob @Galileo88 can you please take a look at this?

DasSkelett commented 3 years ago

@OhioBob can you finally take a look at this? This keeps creating problems for users of your mod!

DasSkelett commented 3 years ago

Would it help you if we move the metadata into our repositories, to reduce the maintenance burden on your side? Then you only have to manage version files, but if necessary we could also hardcode compatibility data in the netkan files.

DasSkelett commented 3 years ago

This PR has been ignored for a very long time now. In the interest of our users, since this actively breaks their installations and I keep getting reports about this, we have decided to de-meta these metanetkans and pull them back into our NetKAN repo, where we can properly fix and maintain them.