Scatterer - JNSQ / CKAN minor issue

[Jognt]

JNSQ has "Scatterer - Default Config" set as a dependency in CKAN while it actually provides a cfg itself. This leads to Scatterer reporting double installations of Scatterer because CKAN does not allow installing only Scatterer core and auto-installs the default cfg.

[DasSkelett]

JNSQ has "Scatterer - Default Config" set as a dependency in CKAN

Are you sure? Doesn't look like it in the netkan file:

  "depends": [
    {
      "name": "ModuleManager"
    },
    {
      "name": "Kopernicus"
    }
  ],

while it actually provides a cfg itself.

Also can't confirm that, the included config files seem to depend on the default config files from Scatterer, if I understand the MM syntax correctly:

@Scatterer_config:AFTER[scatterer]
{

@Scatterer_atmosphere:AFTER[scatterer]
{

And the .netkan doesn't have a provides for Scatterer-config:

  "provides": [
    "EnvironmentalVisualEnhancements-Config",
    "Scatterer-sunflare",
    "Kronometer"
  ],

[Jognt]

The ‘double instance’ from Scatterer appears to be caused internally with Scatterer itself. Please disregard.

With regards to CKAN/MM, that looks much different from what I saw when I checked. May have checked an older release.

I will double check and report back. Please stand by.

[Jognt]

Not sure what I was doing. I was probably drawing premature conclusion based on an issue over at scatterer's github. Apologies.

While checking I did see the reason why I had no sunflare in scatterer mode: JNSQ Netkan: "Provides scatterer sunflare" JNSQ Sunflare: "@scatterer_sunflare"

Removing the @ should be enough: https://github.com/Galileo88/JNSQ/blob/master/GameData/JNSQ/JNSQ_Configs/Scatterer/sunflare01.cfg

[DasSkelett]

While checking I did see the reason why I had no sunflare in scatterer mode: JNSQ Netkan: "Provides scatterer sunflare" JNSQ Sunflare: "@scatterer_sunflare"

Yes indeed, good catch. We had this problem with multiple planet packs now. It looks like they would provide the entire sunflare config themselves, but they actually only modify the default ones, just like the Scatterer-config. Tricky ModuleManager syntax.

Removing the @ should be enough: /GameData/JNSQ/JNSQ_Configs/Scatterer/sunflare01.cfg@master

This has to be solved in the CKAN metadata, the "provides": "Scatterer-sunflare" should be changed to a "depends": "Scatterer-sunflare-default" If the JNSQ team decides to provide the full sunflare config in the future, it will have to be changed it back.

I'm going to do a PR here to update the NetKAN file (since it's hosted in this repo), and then we also have to backport the change to earlier releases in the CKAN-meta repository.

[Jognt]

Cheers. Shall I close this or keep it open?

[DasSkelett]

Keep it open, I'm going to close it with the PR.