search

Galladite27 / ONScripter-EN

Continuation of ONScripter-EN with updated dependencies and more features and bugfixes. Also see onscripter-insani (https://github.com/insani-org/onscripter-insani), our sister project.
http://galladite.net/~galladite/ons-en/
GNU General Public License v2.0
49 stars 9 forks source link

Possible Issue in Post-Credits Scene in Moonshine #15

Open nafnlj opened 9 months ago

nafnlj commented 9 months ago

ONScripter-EN Version: 6.28 (Linux) Novel: Moonshine (http://altogether.insani.org/2008/4.html)

Issue: The novel ran with no issues through the end credits. I encountered what I think were some minor issues in Moonshine's post-credits scene, Afterglow.

Steps to Reproduce: Play Moonshine to the end and watch the post-credits scene.

Terminal output: I launched Moonshine from the terminal with an option to change the save path. The following terminal output appeared around the time the issues began.


 ***[Warning] Parse Issue at line 7425 (*s_01:4408) - command [i] is not supported yet!! ***
    (String buffer: [i])
 ***[Warning] Parse Issue at line 7536 (*s_01:4519) - command [ignoreinput] is not supported yet!! ***
    (String buffer: [ignoreinput])
 ***[Warning] Parse Issue at line 7936 (*s_ep_end:1) - command [lr_trap2] is not supported yet!! ***
    (String buffer: [lr_trap2])
 ***[Warning] Parse Issue at line 7956 (*s_ep_end:21) - command [unignoreinput] is not supported yet!! ***
    (String buffer: [unignoreinput])

Line 7425: Dialogue line in last scene before end credits. I had not observed any strange behavior at this point.

Line 7536:

ignoreinput

This comes right between the last line of dialogue and the start of the end credits. I searched the 0.txt and saw that this is the only time ignoreinput is used, leading me to suspect this had something to do with the issue.

Line 7936: lr_trap2 off Line 7956: unignoreinput

These both occurred after the final line of dialogue in the post-credit scene and before the novel returned to the main menu.

Galladite27 commented 9 months ago

A couple of observations: The command "i" not recognised is an error in the script. It should print text to screen but it's not marked as 1-byte text using a backtick so it's treated as a command.

The commands "ignoreinput" and "unignoreinput" don't exist according to the API reference, and no other mention of them is made in the script. Possibly the devs copying a command from another game without copying its definition? Strange.

lr_trap2 is marked in the API reference as being supported by onsen, so this may well be an engine bug.

The "entering of automode" is actually intended behaviour triggered by the "autoclick" command.

About certain letters becoming transparent, I'd have to look further into this. However, everything else besides lr_trap2 not being detected seems to be issues with the script, not the engine.

nafnlj commented 9 months ago

I forgot to upload screenshots to show what I mean with the text -- I noticed when looking again that they're also mixing backgrounds together. Out of curiosity, I tried removing the ignoreinputs from 0.txt but doing so did not change the game's behavior.

moonshine-text-issue2

moonshine-text-issue