Continuation of ONScripter-EN with updated dependencies and more features and bugfixes. Also see onscripter-insani (https://github.com/insani-org/onscripter-insani), our sister project.
There's a ton of various warnings we have, this resolves most of them, with the intent to introduce no functional changes. There's a few warnings I haven't addressed yet due to either being unsure how to fix it without introducing a functional change, or them only appearing on Linux/when building our deps. I'll work on those in another PR.
Some categories of issues along with a few select issues:
Unused variable: These range from parameters that aren't used, because they're a base class impl, or a callback that doesn't need the parameters, to code that's been orphaned and is unclear if they're needed anymore, to code that's only used on some platforms, but are visible on all of them. Depending on the scenario, these were deleted, their names removed from function definitions, or casted to void to let the compiler know it's intentional.
Case fallthrough: These were all straightforward and intentional. Used a comment to let gcc know. (There's also a C++17 attribute for this, but we're on C++98.)
Function casting: GetProcAddress just will always give us warnings due to how GCC handles function conversions and it's return type. Switched to using a wrapper provided by SDL to avoid it.
We might want to make macros to use instead of void casting unused variables to make their situations clearer, but for now I figured that simpler was better.
There's a ton of various warnings we have, this resolves most of them, with the intent to introduce no functional changes. There's a few warnings I haven't addressed yet due to either being unsure how to fix it without introducing a functional change, or them only appearing on Linux/when building our deps. I'll work on those in another PR.
Some categories of issues along with a few select issues:
GetProcAddressjust will always give us warnings due to how GCC handles function conversions and it's return type. Switched to using a wrapper provided by SDL to avoid it.We might want to make macros to use instead of
voidcasting unused variables to make their situations clearer, but for now I figured that simpler was better.