search

GalleyBytes / terraform-operator

A Kubernetes CRD to handle terraform operations
http://tf.galleybytes.com
Apache License 2.0
357 stars 47 forks source link

fix configMapSelector typo #161

Closed isaaguilar closed 10 months ago

isaaguilar commented 10 months ago

fixes from configMapSeclector to configMapSelector in the crd.

isaaguilar commented 10 months ago

Fixes https://github.com/GalleyBytes/terraform-operator/issues/153

davhdavh commented 9 months ago

Why did you keep the misspelled one? the change to the go-code clearly shows it could never parse it since it was using the right name in go

isaaguilar commented 9 months ago

Both the misspelling and correct spelling works for me. When unmarshalling, the un-marshaller correctly populates the variables from by reading the associated tags (json:"configMapSelector,omitempty" & json:"configMapSeclector,omitempty").

I didn't fix anything here except a new variable name that preserves the old tag in case it was working a certain way for someone else.