Media key doesn't work ootb with beta 2 on HP Falco

[jeremy447]

The media key doesn't work ootb with beta 2 on HP Falco. They seems to act like function key (F1,F2,...). I notice that if I choose "Chromebook | Right alt overlay" in "Keyboard settings" the media key works but it seems there is no way to use a combo to use them as function keys.

An other user has the same problem : https://www.reddit.com/r/GalliumOS/comments/44yd8s/no_keyboard_keys_on_hp14_on_beta_2/?sort=new

By the way thanks for the beta 2 !

[reynhout]

The intended behaviours are:

• Chromebook | No overlay | F keys mapped to media keys
  • top row are media keys, Fkeys are not accessible
• Chromebook | Right alt overlay
  • top row are F keys, media keys are accessible by using Right-Alt as the modifier
• Chromebook | Right alt overlay | F keys mapped to media keys
  • top row are media keys, F keys are accessible by using Right-Alt as the modifier
  • (this is the default for 1.0beta2 on Chromebooks, but if you have preexisting user config, might require selection)
• Chromebook | Search overlay
  • top row are F keys, media keys are accessible by using Super (Search) as the modifier
  • (this was the default for 1.0beta1)
• Chromebook | Search overlay | F keys mapped to media key
  • top row are media keys, F keys are accessible by using Super (Search) as the modifier

Can you test those layouts on the FALCO and tell us which one(s) are not working correctly, and what happens instead?

Thanks!

[hugegreenbug]

Falco has different keys, so it is possible that the keyboard maps are not working as expected.

Which keyboard map are you using? You can find out in Settings->Keyboard->Layout. If you verify that the keys are not doing what they should, can you paste the output of xev for each media key? Thanks.

[jeremy447]

I use the French (Français (variante)) layout. Here is the xev for each media key with the default "Chromebook | Right alt overlay | F keys mapped to media keys" :

http://pastebin.com/XVM6xcgW

[divvykev]

I have the same issue if I install directly from USB but updating using dist-upgrade the media keys work.

[divvykev]

Chromebook Search Layout makes the media keys work fine with right Alt working the rest.

Need to change it from default after install though.

[ghost]

What? That doesn't sound right...

[divvykev]

Works like a dream

[jeremy447]

By the way the keys that are "unlocked" with "Alt Gr" (the third character on the key) like the @ doesn't work too.

https://c2.staticflickr.com/4/3823/12291162516_b1a52b113d_k.jpg

[ghost]

Oh, joy. You're probably best off switching to a layout that uses the search key. I think out keyboard layouts are currently screwed up though (based on reading this thread) so I don't know if that will work.

[jeremy447]

Any news on this ? It's a very annoying bug :D

I tried this script (https://github.com/dnschneid/crouton/blob/master/targets/keyboard) in Manjaro (with LWIN replaced by I225) but that doesn't seems to work either (same kind of behavior I think).

[jeremy447]

By the way I think that worked perfectly with beta 1 and the fix hugegreenbug showed to me :

$ sudo dpkg -i xkb-data-i18n_2.12-1ubuntu1-galliumos3_all.deb xkb-data_2.12-1ubuntu1-galliumos3_all.deb 
# gedit /usr/share/X11/xkb/symbols/chromebook 
- Replace all LWIN to I225 

[jeremy447]

I made some big progress :

• If I choose the "French" keyboard layout all the "standard" keys works. I was using "French Legacy", the default choice at the install, that doesn't seem to work well here.
• If I choose "Chromebook | Search overlay" in Keyboard model, the media keys works without the need to use the overlay key and that the behavior I want.
• The overlay key in "/usr/share/X11/xkb/symbols/chromebook" is wrong for me, it's I225 instead of LWIN for the "search" key.
• With the I225 change every mapping key is working except for the media keys ( don't map to F keys). I didn't managed to make them work, so I removed them from "/usr/share/X11/xkb/symbols/chromebook".
• I noticed in "/usr/share/X11/xkb/symbols/chromebook" that the mapping <AE01> { overlay1=<FK01> }; allow us to use the numbers keys to map the F keys. So I use this to access the F keys and it's better than mapping the media keys because there is 12 "numbers" keys.

To summarize this is my "/usr/share/X11/xkb/symbols/chromebook" file that seem to work perfectly :

// This mapping assumes that inet(evdev) will also be sourced
partial
xkb_symbols "overlay" {
    key <I225> { [ Overlay1_Enable ], overlay1=<I225> };

    key <AB09> { overlay1=<INS> };

    key <LEFT> { overlay1=<HOME> };
    key <RGHT> { overlay1=<END> };
    key <UP>   { overlay1=<PGUP> };
    key <DOWN> { overlay1=<PGDN> };

    key <AE01> { overlay1=<FK01> };
    key <AE02> { overlay1=<FK02> };
    key <AE03> { overlay1=<FK03> };
    key <AE04> { overlay1=<FK04> };
    key <AE05> { overlay1=<FK05> };
    key <AE06> { overlay1=<FK06> };
    key <AE07> { overlay1=<FK07> };
    key <AE08> { overlay1=<FK08> };
    key <AE09> { overlay1=<FK09> };
    key <AE10> { overlay1=<FK10> };
    key <AE11> { overlay1=<FK11> };
    key <AE12> { overlay1=<FK12> };

    key <BKSP> { overlay1=<DELE> };

    key <LALT> { overlay1=<CAPS> };

    // For some strange reason, some Super_R events are triggered when
    // the Search key is released (i.e. with overlay on).
    // This maps RWIN to a dummy key (<I253>), to make sure we catch it.
    key <RWIN> { [ NoSymbol ], overlay1=<I253> };

    // Map dummy key to no symbol
    key <I253> { [ NoSymbol ] };
};

[hugegreenbug]

@Paviluf That looks good. I will add that soon.

[ghost]

(pr is a thing that git supports)

[hugegreenbug]

@ColtonDRG Good point. @Paviluf you can make a pull request for this in https://github.com/galliumos/xkeyboard-config. However, the keyboard maps are in patch, so you would need to add this to the patch. Also, it would be good to have this in a separate keymap and not just a change to the original chromebook file in symbols. If you need help with this, I can help.

[jeremy447]

I really don't know how to do that :(

[ghost]

Oh, you don't know how to use git?

[jeremy447]

I just know how to clone a repo that's all :D

[hugegreenbug]

git clone https://github.com/galliumos/xkeyboard-config

Don't worry about adding to the patch. I'll do it. I'll also make more maps for falco. I was working on #140 before I got to this one since I was thinking that we would have to change the whole overlay strategy. Fortunately, I think I have a solution for it, so then I'll get to this issue.

[ghost]

No, you'll want to fork it first. You also need to add your SSH keys. Then clone your copy using the SSH URI and make your changes, then add, commit, and push your changes and come back to GitHub to create a pull request.

[hugegreenbug]

oh right :)

[jeremy447]

I have made a pull request. I don't know if it will work :D

[hugegreenbug]

It looks good, but it would be nice if you could put your changes into new files and leave the existing symbol files alone. The other maps work fine for other chromebooks, just not for Falco and maybe the Pixels.

[hugegreenbug]

I added @Paviluf 's maps to the package in testing. This creates 2 new maps with falco/pixel/pixel2 in the names.

[hugegreenbug]

@Paviluf were discussing things here: https://github.com/GalliumOS/xkeyboard-config/commit/5fa90e52f7c6fb09af68a865935263f8988862bd#commitcomment-16226173 .

This was @Paviluf most recent comment:

Do you have a suggestion for another key to turn into the capslock key?

What do you think of left shift : key <LFSH> { overlay1=<CAPS> }; I tried it and that work great.

I think I will add the second row to your maps to be consistent.

I didn't managed to make the media key work as F key (and vice versa) with the overlay key, so I don't know if it's possible on Falco. Even if it work it's really useless to have 2 F keys rows I think and that lead to my next comment.

For consistency sake, we should do something similar for the falco ones and have two keyboards where the media keys are F keys.

Since beta2, our default keyboard made the F keys media keys by default (without a special key).

What do you think of keeping only the F key with the overlay on numbers key ? That work well and that allow us to have access to all 12 F keys. Honestly what the point of having 2 F keys row ?

[hugegreenbug]

Ok, left shift sounds fine to me for the maps with alt overlays.

Yeah, two rows doesn't make a whole lot of sense, but we have already done it and I think it will confuse people if we remove it or change it. Recently, I used the keys: 0, -, + for toggling the keyboard backlight, reducing the kbd backlight, and increasing it. That will only work on models that have a keyboard backlight.

[ghost]

Woah, woah! What now? Left shift? How about right shift? I personally use the left one whenever I'm going for the ordinary shift characters. I think mapping the left shift to do something different is a bad idea. Did I miss something?

[hugegreenbug]

It is only for when you press the overlay key, not all the time.

[ghost]

Ok. Wait, so it would require pressing right alt, left shift, and the key you want? That sounds like a game of finger Twister to me. (or am I missing something, again?)

[hugegreenbug]

No, you got it. It does sound painful :)

[jeremy447]

F keys

I think we can move the F keys to numbers keys because it's more logical. Let me explain, now we have the media keys and numbers keys that can act as F keys and it's really not necessary to have 2 keys row that do the same thing. Moreover, with numbers keys you have all the 12 F keys instead of 10 with media keys and there is the numbers to identify easily the F key (eg. F11). To avoid confusing users we simply should announce the change on the news section of the site.

@hugegreenbug you said me that you wanted some consistency and I think that will add some because Falco act differently and doesn't seem to be able to have the media keys acting as F keys with an overlay.

Caps Lock

Hugh removed the capslock (overlay + left alt) for the legitimate case where you want to switch to a virtual terminal. In that case you need to press an F key + Ctl + Alt. Since you would be using the right alt key to turn the media key into an F key, then you need the left alt to make that key combination. That's why I suggest to use the left shift (with the overlay key) to enable capslock because for now it's not possible anymore and it's a really useful feature.

so it would require pressing right alt, left shift, and the key you want?

@ColtonDRG Not at all :D To enable capslock, you simply press the overlay key (eg. right alt) and left shift (of course you release the keys) and you start typing in caps ! No finger Twister.

[hugegreenbug]

@Paviluf I've added additional keymaps for falco and I changed a few things. The new maps are to provide the same options as the other keymaps for other models. The things I changed are the capslock key to be the right shift with the right alt overlay for all right alt overlay maps and to map the full screen key (F4) to the appropriate key code. This new package is in testing.

[jeremy447]

@hugegreenbug Thank you for your work but unfortunately there is a lot of problems with these changes :(

• F keys mapped to media keys doesn't work : Act as media keys regardless of the "falco" map chosen. With the overlay key pressed, with F mapped maps, the media keys does nothing. With the overlay key pressed, and the others maps, the media keys always act as media keys.
• Insert doesn't work
• Caps lock doesn't work
• In chromebook_m_falco caps lock is missing
• More ?

I don't know if it's possible to make the media keys act as the other Chromebooks on Falco. That never worked.

Just for you to know, even if it's not a problem since there is an other overlay key, right alt (Alt Gr) can't be used as overlay key, at least, on french keyboard, because it's used for the third letter on some keys like the number keys ;)

[ghost]

I disagree. Caps lock is the worst and nobody should ever use it for anything ever.

[jeremy447]

I disagree. Caps lock is the worst and nobody should ever use it for anything ever.

What do you mean ?

[ghost]

I just don't use caps lock. I would much rather hold shift.

[jeremy447]

Ok but that shouldn't prevent others to use it since it don't impede you in any way ;)

[jeremy447]

@hugegreenbug I know that you want to keep the current way of dealing with keyboards but it seems to be quite hard to make it work the same for all the Chromebooks. If we simplify it like I did here it will ease things to make all the current and probably future Chomebooks works the same. It will need less work too :D

What do you think ?

[hugegreenbug]

@Paviluf Your symbol file won't work for all models since not all models have the search key as keycode 225. You are right that I can reduce some of these symbol files.

[hugegreenbug]

@Paviluf The magic is really in the keycode files, not the symbol files. I removed all of the falco symbol files and just added an I225 overlay line in the symbol files for the search overlay. I've uploaded the latest version to testing. Would you mind testing it? Thanks.

[jeremy447]

Would you mind testing it

With pleasure :) It's still broken ! If you want me to report each key that work or don't, I can but I will need some time. There is a lot to test and the maps don't seems to behave the same.

[hugegreenbug]

What's broken? You don't need to test the standard chromebook ones, just the ones with falco in the name. Yes, it will help if you can test each key.

[hugegreenbug]

@Paviluf Is there any more information you can give us? We don't want to push the testing package without knowning if it helps or not. Thanks.

[jeremy447]

I need time to test all keys. It's really annoying to test everything ;) I will try to do it this week.

[jeremy447]

This is my results :

Right alt : F : Don't work F (numbers) : Work (F1 to F10 I think) MEDIA (no overlay) : Don't work INS : Don't work CAPS : Work DEL : Work HOME END PGUP PGDN : Work

Right alt F mapped : F : Work F (numbers) : Work (F1 to F10 I think) MEDIA (no overlay) : Work INS : Work CAPS : Work DEL : Work HOME END PGUP PGDN : Work

Search : F : Don't work F (numbers) : Don't work MEDIA (no overlay) : Work INS : Don't work CAPS : Don't work DEL : Don't work HOME END PGUP PGDN : Don't work

Search F mapped : F : Work F (numbers) : Work MEDIA (no overlay) : Work INS : Work CAPS : Work DEL : Work HOME END PGUP PGDN : Work

I tested it with GalliumOS 1.0 on live USB (I'm testing Fedora) with English layout.

[hugegreenbug]

Were you testing the package in testing?

[jeremy447]

Of course no %-) I will test the testing one asap.

[hugegreenbug]

Ok, thanks. For the Alt overlay configurations, the capslock moved to the right shift key.

[jeremy447]

I hope this time it's good !

Right alt : F (overlay) : Work F (numbers) : Work (F1 to F10 I think) MEDIA (no overlay) : Work INS : Work CAPS : Work DEL : Work HOME END PGUP PGDN : Work

Right alt F mapped : F (no overlay) : Don't work (work with overlay) F (numbers) : Work MEDIA (overlay) : Don't work (work without overlay) INS : Work CAPS : Work DEL : Work HOME END PGUP PGDN : Work

Search : F (overlay) : Don't work F (numbers) : Don't work MEDIA (no overlay) : Work INS : Don't work CAPS : Don't work DEL : Don't work HOME END PGUP PGDN : Don't work

Search F mapped : F (no overlay) : Don't work (work with overlay) F (numbers) : Work MEDIA (overlay) : Don't work (work without overlay) INS : Work CAPS : Work DEL : Work HOME END PGUP PGDN : Work

[hugegreenbug]

Thanks. I'll fix the issues.