search

GalliumOS / galliumos-distro

Docs, issues, and artwork sources for GalliumOS
https://galliumos.org/
GNU General Public License v2.0
347 stars 11 forks source link

Keyboard does not adjust screen brightness on Pixelbook #573

Open iancrossfield opened 4 years ago

iancrossfield commented 4 years ago

Issue:

The keys that adjust the screen brightness on my laptop don't perform their function in GalliumOS. When I press the "increase screen brightness" button, the little 'screen brightness' graphic shows up in the upper-right corner but the actual brightness perceived by the eye is unchanged. The "reduce brightness" key just brings up the "Display" ("configure screen settings and layout"). When I reboot into ChromeOS, the keys perform their desired function.

I can adjust the brightness at the command line, however, with (e.g.) xrandr --output eDP-1 --brightness 0.7 which works as desired.

Though xbacklight just gives me:

No outputs have backlight property

I'm running the following system on a Pixelbook 2017 ("Eve"), kernel "Linux chrx 4.16.18-galliumos":

NAME="GalliumOS" VERSION="3.1 (Bismuth)" ID=galliumos ID_LIKE="ubuntu debian" PRETTY_NAME="GalliumOS 3.1" VERSION_ID="3.1" HOME_URL="https://galliumos.org/" SUPPORT_URL="https://galliumos.org/" BUG_REPORT_URL="https://https://github.com/GalliumOS/galliumos-distro/issues" VERSION_CODENAME=bismuth UBUNTU_CODENAME=bionic

I installed into dual-boot mode via chrx. I partially reset the firmware, but haven't yet used the "Suzy-Q" USB cable to fully reset everything.

The xrandr command-line workaround is bearable, but a more elegant workaround would eventually be desirable.

ghost commented 4 years ago

The Pixelbook has a different keyboard layout than most other Chromebook models, so we'll need to add a new layout to xkeyboard-config

satmandu commented 4 years ago

@iancrossfield This patch fixes screen brightness changes for me on nocturne using ubuntu and a 5.9-rc5 kernel, can you see if it works for eve too? (I can use the default gnome brightness scroller to change brightness now.)

https://gist.github.com/satmandu/d6c2192f66cd14525049fd34d356d71d

(As I understand it the xrandr command can lower the brightness of the image on the screen but doesn't actually control the brightness.)

I would also be interested in having a keyboard layout which supports the screen brightness change keys.

There is this: https://github.com/yusefnapora/pixelbook-linux/issues/30 But that's a hack which doesn't change the layout if you want to use a wayland compositor as is the default in ubuntu these days.