GalloDaSballo / Apollon-Review

Notes for the Apollon Solo Security Review
0 stars 0 forks source link

`enableLiquidationAndRedeeming` pauses liquidations which can be problematic #42

Open GalloDaSballo opened 3 months ago

GalloDaSballo commented 3 months ago

Impact

enableLiquidationAndRedeeming is pausing both redemptions and liquidations

Those 2 operations have a very different purpose, with redemptions helping with the peg and acting as a pre-liquidation and liquidations being a necessary tool to make the system work

Due to this, liquidations should never be disabled unless a major bug was discovered

Mitigation

Separate enableLiquidationAndRedeeming to disable redemptions and liquidations separately

sambP commented 2 months ago
Screenshot 2024-08-28 at 10 23 38 PM