GalloDaSballo / Apollon-Review

Notes for the Apollon Solo Security Review
0 stars 0 forks source link

`_getCurrentPythResponse` can benefit by having more validation #46

Open GalloDaSballo opened 3 months ago

GalloDaSballo commented 3 months ago

Impact

Pyth works as follows:

The reason why Pyth includes a confidence interval is due to the impossibility of chosing a single price that is the "correct" price

Mitigation

Consider implementing additional checks, you could take inspiration from Euler's multi-audited feeds: https://github.com/euler-xyz/euler-price-oracle/blob/master/src/adapter/pyth/PythOracle.sol