Closed FlorianKothmeier closed 9 months ago
Thanks for the feedback!
What's the preferred development approach here? Should changes from the review stay as a separate commit or be squashed into the first one?
Separate commits are fine for such small changes like this. We squash the whole PR branch before merging.
Is #2309 an acceptable solution to this problem too?
@peace-maker Yes, that patch sounds good. However, this still leaves he old behavior when the challenge files could not be determined automatically. But this is probably good enough
We can still add the change to include context.binary
when no exe was set nor found. I'd still like to avoid crashing when trying to open the './path/to/binary'
file if you only specify a remote host and port. There often are remote-only challenges without a handout.
@peace-maker I just added a commit that implements the fallback you suggested for remote-only challenges. Sorry that it took me this long
pwn
template only setcontext.binary
when an argument was specified and only defined a placeholder path instead. It would be more reasonable to setcontext.binary
even if no path was specified as pwntools can automatically determine the correct settings for the binary when you fill in the placeholder path.Old template without specifying target binary as argument:
New template without specifying target binary as argument:
Partially resolves #2276