Add `port`, `gdb_args`, and `gdbserver_args` to gdb.debug()

gfelber commented 3 months ago

added two arguments to gdb.debug()

port: specifies the port that should be used by the gdbserver, this is useful for alpine, because alpine doesn't support the default openssh port forwarding feature, due to a minimalistic version of openssh
gdb_args: allows forwarding arguments to the gdb binary spawned by gdb.attach() (just a passthrough)

also downgraded "GDB Python API is supported only for local processes" to a warning, because it seems to work.

These changes are made for compatibility with my pwntools "plugin" vagd which currently uses a workaround on Pwngd.debug() (basically the same behaviour as the patch)

gfelber commented 3 months ago

additionally added the optional argument gdbserver_args, which could be useful for some setups or troubleshooting

gfelber commented 1 month ago

Addressed change requests in 7305502.

regarding:

Your "plugin" looks nice, do you have plans to upstream features? I'd rather have nice docker and qemu integration than patchwork changes to make the external tool work. :D

The initial reason this has turned into a "plugin" i maintain myself is so i can basically make changes whenever i encounter a problem or run into an issue (or want to add a new feature).

Generally speaking I don't mind adding the functionality to upstream, but this might require some time because

i will have to rewrite a lot of stuff to work with python2.7
i will have to read into the pwntools project to understand exactly how your docs, code structure and testing setups work I would probably also keep my repo around, so it's easier for me to add and test new stuff

Maybe we can move this discussion somewhere else? My discord tag is @gfelber (I'm also on the official discord server).

Gallopsled / pwntools

Add `port`, `gdb_args`, and `gdbserver_args` to gdb.debug() #2382