search

Gallopsled / pwntools

CTF framework and exploit development library
http://pwntools.com
Other
11.99k stars 1.7k forks source link

Fixed x86 GAS options #2449

Closed 9x14S closed 1 month ago

9x14S commented 1 month ago

I fixed the word size options accepted by GAS for the x86 architecture from -32/-64 to --32/--64.

Source: https://sourceware.org/binutils/docs/as/i386_002dOptions.html

peace-maker commented 1 month ago

Thank you for your contribution! GAS uses getopt_long_only to parse argv and thus supports - as well as -- for long options, so this isn't necessary. Did you encounter problems with some as version with different behavior?

I don't think this change helps code readability if it's only to align with the documentation.

9x14S commented 1 month ago

I didn't have any issues with the assembler, I just noticed that and thought it was a bug.

Thanks for your reply! Guess I'll close this PR then.

peace-maker commented 1 month ago

Thank you for your help though, please come again if you notice something else 👍