search

GaloisInc / BESSPIN-FETT-Portal

The web-based portal used by FETT Researchers to manage Target instances.
Apache License 2.0
0 stars 0 forks source link

Fix researcher UI Issues #401

Closed kurthopfer closed 4 years ago

kurthopfer commented 4 years ago

Remove the ip from the table - We want them ip next to the environment id so the researcher notes it in their issues opened, also not a fan of the look.

Fix status in the modal popup bug that was introduced

Kizjkre commented 4 years ago

We want them ip next to the environment id so the researcher notes it in their issues opened

Makes sense. IP is removed in a commit in uiux-fixes. I also thought it looked a little crowded, but I was trying to address #316.

Fix status in the modal popup bug that was introduced

Was not aware of this. It seems like it only appears with the Material UI icons, namely, queueing and terminated states. I'll see if I can replace those with SVGs. Worst comes to worst we could always go back to the exclamation icons. Again, this was to address #316.

kurthopfer commented 4 years ago

@Kizjkre we are doing Sprint Planning Monday. Let's only address items that have rolled through sprint planning process and are tagged with current sprints. There was a considerable amount of iteration on the web portal from a researcher perspective and I don't want to change items in there unless function is impacted or it has rolled through all of us in SP. -k

alex-fivetalent commented 4 years ago

I am noticing a few changes that should probably be fixed before we move this to prod.

Kizjkre commented 4 years ago

I can provide some context for those.

  • The icons for the researcher dash show a red square on some of the status icons.

I can remove that, and it's a very quick fix.

  • The sidebar font sizes no longer match the mockups.

The Dashboard text on the sidebar kept getting cut off by the main content (on my screen) so I made the font size scale with screen width.

  • The widths of the main content cards on researcher/admin have been stretched to full screen.

This is also a quick fix. However, it seems like the content cards are full width on the mockups. I just took a brief look at them, so feel free to correct me on that.

  • There is a line next to scrollbar in the researcher dash.

I have no idea when this popped up. It doesn't show up for me, so I'm not able to debug it.

  • There is a partial screen vertical scrollbar which doesn't match the other ones on both the learn and dash screens

I'm not sure what this means. Can you elaborate?

alex-fivetalent commented 4 years ago

on the right hand side of the page for learn and dash there are scrollbars on the far right that were introduced. I think they look like a combination of browser default and the custom one. It may look better to remove them.
image

alex-fivetalent commented 4 years ago

@Kizjkre I noticed that now scrolling is disabled on a few of the pages. Most likely this happened when you added the overflow: hidden to the . For example, if you are on the launch page and you make the screen smaller you wont be able to scroll to the content. Same as a few of the screens on the admin side.

Kizjkre commented 4 years ago

I just fixed that so it adds a scrollbar when you start scrolling (when it is possible to scroll).