search

GaloisInc / BESSPIN-Tool-Suite

The core tool of the BESSPIN Framework.
Other
6 stars 2 forks source link

Infotainment canlib fix #1109

Closed lolsborn closed 3 years ago

lolsborn commented 3 years ago

Updated constants to reflect changes to the canlib autogenerated header. Please take a look to ensure the constants I substituted are the right values.

dmzimmerman commented 3 years ago

Um... I'm kinda curious as to why the name changed back to INFOTAINMENT_STATE from MUSIC_STATE, since I had made that change in the first place to better reflect what the state actually meant.

dmzimmerman commented 3 years ago

(did I perhaps forget to make the change in the CSV file that generated the headers? I didn't think so, because I thought I generated the headers the last time I made changes, but maybe...)

podhrmic commented 3 years ago

I changed it in the CSV because when I was drawing the state diagrams, MUSIC_STATE seemed to be an odd name. Happy to change it back if you have a strong opinion about the name.

dmzimmerman commented 3 years ago

It can be either... it's just that the state actually contains information only about the music (playing/not, which station, volume level) and not about the infotainment system as a whole (e.g., there are also x/y/z coordinates for the map, etc. that are separate messages).