Closed njshanahan closed 3 years ago
Thanks Nicholas. I am currently working on the partial credit, and I have actually seen the problems with 761. Btw, there are more problems than the what you have identified. For example, part 02 scoring is wrong, and the FreeRTOS scoring is not done well. I am reducing this test to only 2 parts, and I will push these modifications to the partial-credit branch that is still under construction.
I will leave this ticket open till that branch is merged.
Thanks @rtadros125. Out of curiosity, what is the problem with Part 2? I'm wondering if our score is correct or if it may change.
@njshanahan here's the commit with the changes: 2530fadbcb364d05cb5cedda4e53b88f0833844e
After reviewing
test_761.c
, I believe that Part 3 does not contain a vulnerability as implemented.The
contains_char_malicious()
function will match the first character ('S') within the buffer (i.e. the beginning of the buffer) and free the pointer as expected. The pointer is never incremented, so no violation has occurred. See the test output below.I believe that Part 3 should be reported as
NONE
, in which case a processor detecting Part 4 would receive credit for mitigating the vulnerability.Tagging @austinhroach for awareness.