Minor improvements to documentation for hacking HaLVM

GaloisInc / HaLVM

The Haskell Lightweight Virtual Machine (HaLVM): GHC running on Xen

BSD 3-Clause "New" or "Revised" License

1.05k stars 88 forks source link

Minor improvements to documentation for hacking HaLVM #122

Closed mspaulding06 closed 7 years ago

mspaulding06 commented 7 years ago

Just made a few very small improvements to the documentation. For instance, adding information on Fedora 26 (which is able to compile HaLVM) and updating commands and package information to make the build process a little smoother.

izgzhen commented 7 years ago

Looks good overall. But I would suggest to make sure that the changed portion still applies to older versions, since it is said so. Or else, provide lines like this:

$ ifconfig # if Fedora 22, 23, 24

$ ip a # if Fedora 25, 26

What do you think?

acw commented 7 years ago

w00t! Thanks!

mspaulding06 commented 7 years ago

@izgzhen I think that just including ip a should be fine if you are okay with that. The iproute package is included in Fedora back to release 22 and should be used where possible since ifconfig is deprecated.

mspaulding06 commented 7 years ago

@acw Did you intend to close the PR without merging?

acw commented 7 years ago

Ah-hah! You solved my brain teaser! Congrats!