GaloisInc / cryptol

Cryptol: The Language of Cryptography
https://galoisinc.github.io/cryptol/master/RefMan.html
BSD 3-Clause "New" or "Revised" License
1.14k stars 126 forks source link

:check-docstrings empty code fences #1704

Closed weaversa closed 3 months ago

weaversa commented 4 months ago

Would it be possible to enable :check-docstrings to also work with empty code fences? For example:

/**
 * Comment...
 * 
 * ```
 * :check property
 * ```
 */
yav commented 4 months ago

Hehe, so this is how this used to work yesterday, and I asked Eric to change it to be explicit :) I just thought that it is a bit odd that the default fence would be for REPL commands, but perhaps this is the most common kind of thing you might write in an example anyway. I don't feel strongly about this either way.

weaversa commented 4 months ago

Thanks @yav! If you don't feel strongly about it, my preference is for empty doc strings to be handled as though they are REPL commands.

RyanGlScott commented 3 months ago

@glguy, is this fixed as of #1706?

glguy commented 3 months ago

@glguy, is this fixed as of #1706?

Yes!