csaf_env_example.ipynb fails & missing readme/description

[podhrmic]

In GitLab by @podhrmic on Oct 20, 2020, 09:27

https://gitlab-ext.galois.com/assuredautonomy/csaf_architecture/-/blob/develop/docs/notebooks/csaf_env_example.ipynb errors with:

---------------------------------------------------------------------------
StopIteration                             Traceback (most recent call last)
<ipython-input-1-8b57ea99c945> in <module>
      8 do_sim = True
      9 while do_sim:
---> 10     comp_input = my_env.step({"autopilot-states": ["Waiting"], "autopilot-fdas": ["Waiting"], "autopilot-outputs": ctrl_signal})
     11     if isinstance(comp_input, bool):
     12         do_sim = False
/builds/assuredautonomy/csaf_architecture/src/csaf/system.py in step(self, component_output)
    213     def step(self, component_output):
    214         """step through the simulation generator"""
--> 215         return self._iter.send(component_output)
    216 
    217     def reset(self):
StopIteration: 
StopIteration: 

See this job log for details.

The notebook is missing from the doc/notebooks/README.md and is missing some description/readme itself, please add a few sentences.

[podhrmic]

In GitLab by @podhrmic on Oct 20, 2020, 12:51

changed title from csaf_env_example.ipynb fails & {-it is not clear what is its purpose-} to csaf_env_example.ipynb fails & {+missing readme/description+}

[podhrmic]

In GitLab by @podhrmic on Oct 20, 2020, 12:51

changed the description

[podhrmic]

In GitLab by @mattclark on Oct 27, 2020, 04:05

Please fix

[podhrmic]

In GitLab by @EthanJamesLewon Oct 27, 2020, 07:55

mentioned in merge request !59

[podhrmic]

In GitLab by @EthanJamesLewon Oct 27, 2020, 08:25

Bugfix PR open! This was caused by changing some things for the f16env.py script, and not in the notebook. This should have been tested, oc, and CI here would have been good.

[podhrmic]

In GitLab by @podhrmic on Oct 27, 2020, 09:15

mentioned in commit d5c4f23126aab86c51f3c4555b03d089ff9438b3