GaloisInc / daedalus

The Daedalus data description language
BSD 3-Clause "New" or "Revised" License
65 stars 11 forks source link

fix pdf-hs-driver parsing rejects (or confirm to be valid rejects) #175

Open mtullsen opened 3 years ago

mtullsen commented 3 years ago

Overview

To Do

Potential errors in the 2020-03-eval corpus

We have a number of variances in the pdf-driver tests. I.e., this test

cd pdf-driver
scripts/get-pdf-tests
scripts/run-tests

Error report from the eval3 corpus

ERROR-A About 70% of your FPs are this ERROR:

INFO:7472 Found xref table.
ERROR:7472 Not enough entries, found UInt 0, but need at least UInt 1

ERROR-B Another 25-ish% is this:

INFO:116 Found xref table.
ERROR:616161 expected "xref"

Those are from files 03/0d/030d6cafff25264297fa3d91dba983d14ed5ba5d69f345078b36c2a0b1c1aa73 and 02/ec/02ec04d85c4a9e65b9693636a8c258875801e6dd1a0dffb8db0d4d124354874a, respectively.

mtullsen commented 3 years ago

The first file, 030d6..., is due to NOT ignoring whitespace pointed to by startxref. the parser should ignore whitespace here.