Closed ESultanik closed 1 year ago
When an array is constructed with no content, https://github.com/GaloisInc/daedalus/blob/daee494e910c846d13cf3af5a2d7b1af6d720bc9/rts-c/ddl/array.h#L90 the content ptr member is initialized to nullptr.
ptr
nullptr
This will lead to undefined behavior due to a null pointer dereference when borrowing its data: https://github.com/GaloisInc/daedalus/blob/daee494e910c846d13cf3af5a2d7b1af6d720bc9/rts-c/ddl/array.h#L147-L149
Adding a check if ptr == nullptr before line 147 reveals that this happens many times during the course of parsing a PDF.
ptr == nullptr
When an array is constructed with no content, https://github.com/GaloisInc/daedalus/blob/daee494e910c846d13cf3af5a2d7b1af6d720bc9/rts-c/ddl/array.h#L90 the content
ptrmember is initialized tonullptr.This will lead to undefined behavior due to a null pointer dereference when borrowing its data: https://github.com/GaloisInc/daedalus/blob/daee494e910c846d13cf3af5a2d7b1af6d720bc9/rts-c/ddl/array.h#L147-L149
Adding a check if
ptr == nullptrbefore line 147 reveals that this happens many times during the course of parsing a PDF.