GaloisInc / dismantle

A library of assemblers and disassemblers derived from LLVM TableGen data
24 stars 5 forks source link

dismantle-arm-xml is dependent on the system locale #18

Closed travitch closed 4 years ago

travitch commented 4 years ago

The code that reads XML in dismantle-arm-xml uses (a strict version of) System.IO.readFile, which is dependent on the system locale. We should change it to use Data.Text.IO (which decodes utf-8 directly from bytestrings).

I built dismantle-arm-xml in a docker container and it failed because the default locale is not sufficient to decode some of the XML files. I don't know what it is, but changing it to utf-8 fixed the problem.