More visibility and linkage

GaloisInc / llvm-pretty

An llvm pretty printer inspired by the haskell llvm binding

Other

28 stars 15 forks source link

More visibility and linkage #78

Closed noughtmare closed 3 years ago

noughtmare commented 3 years ago

Fixes #77

I wasn't completely sure how to deal with the declare function. I could give it FunAttrs as argument like define, but declare doesn't have the garbage collection attribute.

The main changes are:

add linkage and visibility to Declare
add visibility to Define
add linkage and visibility to GlobalAlias

elliottt commented 3 years ago

This looks good to me, thanks for fixing this! I think it would be reasonable to introduce another type like FunAttrs for the declare function, if you'd like to tackle that in a follow-up PR.