search

GaloisInc / macaw

Open source binary analysis tools.
BSD 3-Clause "New" or "Revised" License
203 stars 20 forks source link

parse subroutine type declaration formal parameters #382

Closed Ptival closed 4 months ago

Ptival commented 4 months ago

This is useful for Reopt as we want to get more accurate type information for library functions.

Is this acceptable for other clients?

RyanGlScott commented 4 months ago

Is this acceptable for other clients?

Hard to say, since I don't know if there are any other clients of this code besides reopt. (A GitHub search didn't turn up anything, but that's not conclusive.) My gut reaction is that using a Variable here would be more precise (and arguably better) than using a DIE in most cases, but it's hard to anticipate if there are other use cases where a DIE would be preferable.

This is all to say: I am inclined to make this change and see if anybody complains. (If they do, we can always add the DIEs back alongside the Variables.) It would be worth advertising this API change in the macaw-base changelog as a precaution, however.