GaloisInc / macaw

Open source binary analysis tools.
BSD 3-Clause "New" or "Revised" License
208 stars 21 forks source link

symbolic: Remove redundant unwrapping/rewrapping of register struct #435

Closed langston-barrett closed 2 months ago

langston-barrett commented 2 months ago

There was a lot of redundant unwrapping and re-wrapping of the assignment of TypeReprs to the architecture register context into and out of a StructRepr. Remove this.

Also, add an hlint configuration file to help avoid this in the future, and a Github Actions workflow to enforce this in CI.