macaw-symbolichas some functionality for allocating stack space for spilled arguments. However, many ABIs impose some kind of alignment constraints on the stack pointer. For example, both the AArch32 and x86_64 SysV ABIs specify that the end of the spilled argument list is aligned to 2*w where w is the number of bytes in a word. Since macaw-symbolic has no notion of the ABI in use, its ABI-agnostic code could only ever satisfy such alignment constraints on accident. We should just remove it, and clients wishing to spill arguments to the stack should do so with ABI-specific functionality.
macaw-symbolichas some functionality for allocating stack space for spilled arguments. However, many ABIs impose some kind of alignment constraints on the stack pointer. For example, both the AArch32 and x86_64 SysV ABIs specify that the end of the spilled argument list is aligned to2*wwherewis the number of bytes in a word. Sincemacaw-symbolichas no notion of the ABI in use, its ABI-agnostic code could only ever satisfy such alignment constraints on accident. We should just remove it, and clients wishing to spill arguments to the stack should do so with ABI-specific functionality.