Open brianhuffman opened 4 years ago
We also need to improve the line-breaking and indentation for printing type signatures of methods with multiple arguments; it's pretty bad right now. Here's a selection from the pretty-printed java.math.BigInteger
class:
static java.math.BigInteger multiplyKaratsuba (java.math.BigInteger,
java.math.BigInteger)
static int[] multiplyToLen (int[],
int,
int[],
int,
int[])
static java.math.BigInteger multiplyToomCook3 (java.math.BigInteger,
java.math.BigInteger)
java.math.BigInteger negate ()
As you can see, it's quite hard to read.
A saw-script
JavaClass
value, obtained fromjava_load_class
, prints out a summary of the contents of the JVM class file. For example:However, there are a couple of additional relevant pieces of information that would be good to add here. First of all, we should say whether each method is
static
or not, as that determines whether or not it should take athis
reference as an extra first argument.Also, in addition to the pretty-printed method type signatures, it might be nice to display the type descriptor string which can be used by the new
crucible_jvm_verify
command (as implemented in #884). Perhaps we could display those descriptor-extended names in a comment, but only for names that appear more than once.