search

Galooshi / atom-import-js

Atom plugin for ImportJS
MIT License
36 stars 3 forks source link

APM can't install SQLite3 dependency #18

Open luastoned opened 7 years ago

luastoned commented 7 years ago

Basically node-gyp is super oudated, if you run Windows 10 with some recent compiler (VS2015, VS2017) it will not work, no matter what. The supposedly pre-built binaries are nowhere to be found either, so no SQLite3 is available.

node-pre-gyp ERR! Tried to download(403): https://mapbox-node-binary.s3.amazonaws.com/sqlite3/v3.1.8/electron-v1.3-win32-x64.tar.gz
node-pre-gyp ERR! Pre-built binaries not found for sqlite3@3.1.8 and electron@1.3.15 (electron-v1.3 ABI) (falling back to source compile with node-gyp)

Please consider switching to something different, as this is not the first issue regarding the install process.

trotzig commented 7 years ago

Hi @luastoned, and thanks for reporting your issue!

I've had a few people reporting issues with installing atom-import-js (https://github.com/Galooshi/atom-import-js/issues/12 comes to mind as the most recent one). In most (all?) cases, we've managed to find workarounds.

When you say "consider switching to something different", do you mean move off of sqlite3? It's something I've considered as well, having had issues myself during early implementation of the current version of import-js. I'd be interested to hear if you have ideas for alternatives, or if you'd be willing to explore a different implementation!

It would also be interesting to see more of the log output. In cases when prebuilt binaries can't be found, node-pre-gyp falls back to doing a native build (I believe). Are you seeing issues from that process as well, or is the installation exited right away?

luastoned commented 7 years ago

node-pre-gyp tries to do a native install, which fails because it can't find MSBuild. It tries an oudated way and for VS2017 there is no solution yet: https://github.com/nodejs/node-gyp/issues/1173

As for alternatives, I'm not quite sure what you are storing but https://github.com/kripken/sql.js seems interesting.

trotzig commented 7 years ago

Ouch, that's annoying. I'm currently exploring alternatives: https://twitter.com/henrictrotzig/status/869267951794487297

I would happily move off of node-sqlite3 if there is an alternative. I need something that can persist to a file and allow some kind of querying, allowing concurrent instances to read and write at the same time. All the db interaction is in a file called ExportsStorage, so replacing it shouldn't be too hard. Let me know if you have any ideas!

luastoned commented 6 years ago

Any updates regarding this issue? I still can't install 0.13

trotzig commented 6 years ago

As far as I can tell, no one is actively working on this issue. Any help here is appreciated!