search

Galooshi / happo

Visual diffing in CI for user interfaces
504 stars 16 forks source link

Screenshot too large when there are elements that are partially hidden by overflow containers #136

Open lencioni opened 8 years ago

lencioni commented 8 years ago

If you have markup that looks like this:

<div style="height: 20px; overflow: hidden">
  <div style="height: 200%">Foo</div>
</div>

The resulting screenshot will be 40px tall instead of 20px tall. This is due to the method we added in a5043f839c1f53cf639cfc0ee32db8c186028bea to get the coordinates of all descendants. I'm not sure if this is an actual problem or just a quirk yet, but it seems like it would be good if we can find a good way to fix this.