Lcs in browser - Githubissues

Galooshi / happo

Visual diffing in CI for user interfaces

505 stars 16 forks source link

Lcs in browser #144

Closed trotzig closed 8 years ago

trotzig commented 8 years ago

I made this branch into a PR so that it's easier to keep the discussion going.

The whole PR is still WIP, so I don't think we should merge yet. I unwipped the last commit in the branch by making it draw a simple overlay image (no lcs diffing yet).

lencioni commented 8 years ago

JSON.stringify has been aggressively optimized by browsers over the past few years, since it is so widely used. Hard to top it.

trotzig commented 8 years ago

I thought those comments ^^ would be attached to the commit I posted them on. Apparently not... I find the reviewing UI confusing...

lencioni commented 8 years ago

I think those are more like "cover pages" for your whole review, which is on a PR basis and can span multiple commits.

lencioni commented 8 years ago

FYI, I noticed Travis runs are really slow on this branch (~15min).