search

Galooshi / happo

Visual diffing in CI for user interfaces
504 stars 16 forks source link

Wait for images to load #163

Closed trotzig closed 7 years ago

trotzig commented 7 years ago

The goals of this PR are two-fold:

A: fix #162 by loading images before the screenshot is taken B: re-implement [the screenshotting function from Selenium's firefox driver](https://github.com/SeleniumHQ/selenium/blob/ceaf3da79542024becdda5953059dfbb96fb3a90/javascript/firefox-driver/js/screenshooter.js#L23) and only grab the part of the screen we're interested in (hence the "No crop" name of the PR).

EDIT: I ended up only including the image wait in this commit. Screenshot improvements will be done in another PR (as suggested by @lencioni).

trotzig commented 7 years ago

I'm not done here, but I wanted to get this out so that you can feedback @lencioni.

trotzig commented 7 years ago

Alright, I think we're in a better spot now. This ended up being a lot more complicated than I thought (not the waiting for images part, but the travis build woes).