search

Galooshi / happo

Visual diffing in CI for user interfaces
504 stars 16 forks source link

Pre cropped screenshots #177

Closed trotzig closed 7 years ago

trotzig commented 7 years ago

@lencioni: Can you have a look at these changes if you have a moment? I still have test failures to fix which I won't have time to do until later during the week. So no rush.

trotzig commented 7 years ago

I also need to update the README a little I believe.

lencioni commented 7 years ago

Maybe try updating to Jest 18?

trotzig commented 7 years ago

Good call. I'll try that next.

On Thu, 5 Jan 2017 at 17:54, Joe Lencioni notifications@github.com wrote:

Maybe try updating to Jest 18?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Galooshi/happo/pull/177#issuecomment-270695242, or mute the thread https://github.com/notifications/unsubscribe-auth/AAjS5cXb9LmrmwmlCwEylHiYY8O-1D4uks5rPSA8gaJpZM4LaqhS .

trotzig commented 7 years ago

I found one issue that we should fix. But I won't let that block shipping v4.

oliviertassinari commented 7 years ago

I have been trying to port the happo-target-firefox to work with a docker bases selenium solution. Didn't succeed as you said in the description, selenium does not support it. That's a pretty nice finding!